Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Rename invalid_codeblock_attribute lint to be plural #74131

Merged

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Jul 7, 2020

Lint names should be plural as per the lint naming conventions: https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints

r? @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2020
@ollie27
Copy link
Member Author

ollie27 commented Jul 7, 2020

This will need to be backported to beta as that's the first version with this lint.

@ollie27 ollie27 added beta-nominated Nominated for backporting to the compiler in the beta channel. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 7, 2020
@GuillaumeGomez
Copy link
Member

I didn't know there was a convention for lints. TIL. Thanks a lot!

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 7, 2020

📌 Commit 56fb717 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 7, 2020
…ttributes_name, r=GuillaumeGomez

rustdoc: Rename invalid_codeblock_attribute lint to be plural

Lint names should be plural as per the lint naming conventions: https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints

r? @GuillaumeGomez
@bors
Copy link
Contributor

bors commented Jul 8, 2020

⌛ Testing commit 56fb717 with merge acf6ddde7dd6593e8b24ccabc21dd3f783e14b14...

@bors
Copy link
Contributor

bors commented Jul 8, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 8, 2020
@Dylan-DPC-zz
Copy link

@bors retry p=3 (nominated)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2020
@bors
Copy link
Contributor

bors commented Jul 8, 2020

⌛ Testing commit 56fb717 with merge 97365d567139e768a08c987a1a21d51488704883...

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 8, 2020
…ttributes_name, r=GuillaumeGomez

rustdoc: Rename invalid_codeblock_attribute lint to be plural

Lint names should be plural as per the lint naming conventions: https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints

r? @GuillaumeGomez
@Manishearth
Copy link
Member

@bors retry yield

@bors
Copy link
Contributor

bors commented Jul 8, 2020

⌛ Testing commit 56fb717 with merge 1de8e7d4c2c9288b7da765610b7c1c35cda49b29...

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 8, 2020
…ttributes_name, r=GuillaumeGomez

rustdoc: Rename invalid_codeblock_attribute lint to be plural

Lint names should be plural as per the lint naming conventions: https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints

r? @GuillaumeGomez
@bors
Copy link
Contributor

bors commented Jul 9, 2020

⌛ Testing commit 56fb717 with merge 239acb9e04f94f03f685cf56b6dc44f7ab145100...

@Manishearth
Copy link
Member

@bors retry yield

@bors
Copy link
Contributor

bors commented Jul 9, 2020

⌛ Testing commit 56fb717 with merge 5db778a...

@bors
Copy link
Contributor

bors commented Jul 9, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: GuillaumeGomez
Pushing 5db778a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 9, 2020
@bors bors merged commit 5db778a into rust-lang:master Jul 9, 2020
@pnkfelix
Copy link
Member

pnkfelix commented Jul 9, 2020

discussed at today's T-compiler meeting.

accepted for beta backport.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 9, 2020
@ollie27 ollie27 deleted the rustdoc_invalid_codeblock_attributes_name branch July 9, 2020 14:49
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 10, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 10, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 13, 2020
…ulacrum

[beta] next

Backports of:

* rustdoc: Fix doc aliases with crate filtering rust-lang#73644
* rustdoc: Rename invalid_codeblock_attribute lint to be plural rust-lang#74131
* rustc_lexer: Simplify shebang parsing once more rust-lang#73596
* Perform obligation deduplication to avoid buggy `ExistentialMismatch` rust-lang#73485
* Reorder order in which MinGW libs are linked to fix recent breakage rust-lang#73184
* Change how compiler-builtins gets many CGUs rust-lang#73136
* Fix wasm32 being broken due to a NodeJS version bump rust-lang#73885
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants